Skip to content

[PHP 8.4] Curl new options and constants #4069 を取り込み #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 5, 2025

Conversation

natsuki-engr
Copy link
Contributor

@natsuki-engr natsuki-engr commented Jul 18, 2025

constants.xml と constants_curl_getinfo.xml に関してはファイル全体が未翻訳なので原文のまま取り込んでいます。

@natsuki-engr natsuki-engr marked this pull request as ready for review July 29, 2025 01:59
Copy link
Contributor

@youkidearitai youkidearitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
ありがとうございます!

@@ -15,6 +15,7 @@
libcurl 7.10.5 以降が必要です。
PHP 7.3.0 以降では、7.15.5 以降が必要です。
PHP 8.0.0 以降では、7.29.0 以降が必要です。
PHP 8..0 以降では、7.61.0 以降が必要です。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー遅くなってしまってすみません。
ここの部分ですが、原文では「As of PHP 8.4.0, version 7.61.0 or later is required.」となってますね。
ですのでPHP 8.4.0以降ではが正しいかなと思いました。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらで修正しました!

@youkidearitai youkidearitai merged commit 003899b into php:master Aug 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants